Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic certs rebuild #3447

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Fix automatic certs rebuild #3447

merged 1 commit into from
Dec 13, 2021

Conversation

NelsonVides
Copy link
Collaborator

Please get my certificates to rebuild automatically when they expire, please

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #3447 (ddb0a04) into master (394ec28) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3447      +/-   ##
==========================================
- Coverage   80.85%   80.82%   -0.04%     
==========================================
  Files         415      415              
  Lines       32312    32312              
==========================================
- Hits        26125    26115      -10     
- Misses       6187     6197      +10     
Impacted Files Coverage Δ
src/cassandra/mongoose_cassandra.erl 77.77% <0.00%> (-3.71%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 65.72% <0.00%> (-2.82%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.83% <0.00%> (-0.57%) ⬇️
src/rdbms/mongoose_rdbms.erl 62.54% <0.00%> (-0.40%) ⬇️
src/mod_muc_room.erl 76.97% <0.00%> (-0.29%) ⬇️
src/ejabberd_c2s.erl 89.11% <0.00%> (-0.08%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.31% <0.00%> (+0.11%) ⬆️
src/mam/mod_mam_elasticsearch_arch.erl 86.84% <0.00%> (+1.75%) ⬆️
src/elasticsearch/mongoose_elasticsearch.erl 84.61% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394ec28...ddb0a04. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 12, 2021

small_tests_24 / small_tests / ddb0a04
Reports root / small


small_tests_23 / small_tests / ddb0a04
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ddb0a04
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / ddb0a04
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / ddb0a04
Reports root/ big
OK: 2709 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / ddb0a04
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / ddb0a04
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / ddb0a04
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / ddb0a04
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 301 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / ddb0a04
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / ddb0a04
Reports root/ big
OK: 1880 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / ddb0a04
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / ddb0a04
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / ddb0a04
Reports root/ big
OK: 3108 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / ddb0a04
Reports root/ big
OK: 1726 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

@@ -62,7 +62,7 @@ $(DEVNODES): certs configure.out rel/vars-toml.config
DEVNODE=true $(RUN) $(REBAR) as $@ release)

maybe_clean_certs:
if [ "$$SKIP_CERT_BUILD" = 1 ]; then \
if [ "$$SKIP_CERT_BUILD" != 1 ]; then \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops

Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea

@arcusfelis arcusfelis merged commit 8126d5d into master Dec 13, 2021
@arcusfelis arcusfelis deleted the certs branch December 13, 2021 09:39
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants